View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0017429 | Scribus | Story Editor / Text Frames | public | 2025-02-22 08:30 | 2025-02-27 22:04 |
Reporter | ale | Assigned To | cbradney | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Fixed in Version | 1.6.4.svn | ||||
Summary | 0017429: [PATCH] In the lists, the character offset should never be negative | ||||
Description | Currently, it is possible to set a negative character offset for the lists. For small values it does not look good, for bigger values there are aberrations. I guess that it does not make any sense to have negative values there. | ||||
Tags | No tags attached. | ||||
Patch | Yes | ||||
|
set the minimum value to 0 in the .ui file for the PP and for the styles no-negative-character-offset.diff (1,647 bytes)
diff --git a/scribus/ui/propertywidget_pareffectbase.ui b/scribus/ui/propertywidget_pareffectbase.ui index 1a2670a01..566766135 100644 --- a/scribus/ui/propertywidget_pareffectbase.ui +++ b/scribus/ui/propertywidget_pareffectbase.ui @@ -428,7 +428,7 @@ <string>Paragraph Effects characters offset</string> </property> <property name="minimum"> - <double>-3000.000000000000000</double> + <double>0.000000000000000</double> </property> <property name="maximum"> <double>3000.000000000000000</double> @@ -526,6 +526,12 @@ <header>ui/widgets/form_widget.h</header> <container>1</container> </customwidget> <customwidget> <class>ScrSpinBox</class> <extends>QDoubleSpinBox</extends> @@ -541,12 +547,6 @@ <extends>QComboBox</extends> <header>ui/numformatcombo.h</header> </customwidget> </customwidgets> <tabstops> <tabstop>peCombo</tabstop> diff --git a/scribus/ui/smpstylewidget.ui b/scribus/ui/smpstylewidget.ui index 8a6d90e31..150dd11aa 100644 --- a/scribus/ui/smpstylewidget.ui +++ b/scribus/ui/smpstylewidget.ui @@ -1535,7 +1535,7 @@ A value of 0 means unlimited hyphenations.</string> <string>Paragraph Effects characters offset</string> </property> <property name="minimum"> - <double>-3000.000000000000000</double> + <double>0.000000000000000</double> </property> <property name="maximum"> <double>3000.000000000000000</double> |
|
The change has been applied differently as in some cases it makes sense for drop caps to have negative values, so different code was required to only set the minimum for the other options |
|
Ok, thanks! |
Date Modified | Username | Field | Change |
---|---|---|---|
2025-02-22 08:30 | ale | New Issue | |
2025-02-22 09:55 | ale | Summary | In the lists, the character offset should never be negative => [PATCH] In the lists, the character offset should never be negative |
2025-02-22 09:55 | ale | Patch | No => Yes |
2025-02-22 09:55 | ale | Note Added: 0052094 | |
2025-02-22 09:55 | ale | File Added: no-negative-character-offset.diff | |
2025-02-27 21:25 | cbradney | Assigned To | => cbradney |
2025-02-27 21:25 | cbradney | Status | new => resolved |
2025-02-27 21:25 | cbradney | Resolution | open => fixed |
2025-02-27 21:25 | cbradney | Fixed in Version | => 1.6.4.svn |
2025-02-27 21:25 | cbradney | Note Added: 0052136 | |
2025-02-27 22:04 | ale | Note Added: 0052137 |