View Issue Details

IDProjectCategoryView StatusLast Update
0001653ScribusInternalpublic2005-07-12 04:23
ReporterringercAssigned To 
PrioritynormalSeverityminorReproducibilityalways
Status confirmedResolutionopen 
Platformx86 LinuxOSFedora CoreOS Version3
Product Version1.3.0cvs 
Summary0001653: Convert all PageItem direct member access to use getters and setters
DescriptionConvert all direct access to PageItem members by other classes to use getters. Use Riku's existing setters where possible. Where appropriate, convert members to enum types, and where appropriate rename them.

I think this needs doing at some point. I got part way, but found I was just causing too many errors so I'm putting it on hold for now.
Additional InformationThis is a tracking bug so that all related diffs can be easily located. When the work is complete, this bug will be closed. I'll link bugs containing new patches for this work to this bug.

Issues still to consider:
   - Handling of PageItem types 1 and 3, which appear to be obsolete. Old document compat? Need to do some conversion on import?
   - Should PageItem access its own members directly or via getters? Will the compiler optimise the getter case?
TagsNo tags attached.
Patch

Relationships

related to 0001747 closedfschmid Naming of Object Groups? 
parent of 0001609 closedTsoots [PATCH] Minor PageItem cleanups 
parent of 0001616 closedcbradney PATCH: add getters and properties for all existing setters in PageItem 
parent of 0001623 closedcbradney PATCH: Convert more PageItem members to protected 
parent of 0001632 closedTsoots PATCH: add getters and properties for all existing setters in PageItem (Round 2) 
parent of 0001639 closedcbradney PATCH: Convert PageItem::PType to a protected enumerated member 
parent of 0001655 closedTsoots PATCH: remove last traces of PType 
related to 0002376 closedringerc Source code requests 
child of 0002382 acknowledged Metabug: Code quality, structure, readability 

Activities

ringerc

2005-02-09 08:36

reporter   ~0003670

I'm looking at hacking together a basic test suite for scribus, at least output verification, so can look at picking this up again with somewhat less fear of making a slip of concentration and introducing some nasty lurking bug.

A comprehensive set out output tests would be nice eventually.

ringerc

2005-07-12 04:23

reporter   ~0005545

Due for 1.3.x sometime.

Issue History

Date Modified Username Field Change
2005-02-09 05:55 ringerc New Issue
2005-02-09 05:57 ringerc Relationship added parent of 0001609
2005-02-09 05:58 ringerc Relationship added parent of 0001616
2005-02-09 05:58 ringerc Relationship added parent of 0001623
2005-02-09 05:58 ringerc Relationship added parent of 0001632
2005-02-09 05:59 ringerc Relationship added related to 0001639
2005-02-09 05:59 ringerc Relationship replaced parent of 0001639
2005-02-09 07:51 ringerc Assigned To ringerc =>
2005-02-09 07:52 ringerc Status assigned => new
2005-02-09 07:52 ringerc Description Updated
2005-02-09 08:36 ringerc Note Added: 0003670
2005-02-09 08:42 ringerc Relationship added related to 0001654
2005-02-09 08:56 ringerc Relationship deleted related to 0001654
2005-02-09 08:56 ringerc Relationship added related to 0000165
2005-02-09 08:57 ringerc Relationship deleted related to 0000165
2005-02-09 08:57 ringerc Relationship added parent of 0001655
2005-07-12 04:23 ringerc Note Added: 0005545
2005-07-12 04:23 ringerc Status new => confirmed
2005-07-12 04:23 ringerc Relationship added related to 0001747
2005-08-03 15:46 ringerc Relationship added related to 0002376
2005-08-03 16:26 ringerc Relationship added related to 0002382
2005-08-03 16:27 ringerc Relationship replaced child of 0002382