View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0013720 | Scribus | Usability | public | 2016-02-10 13:04 | 2016-02-27 13:16 |
| Reporter | ale | Assigned To | cbradney | ||
| Priority | normal | Severity | feature | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.5.0 | ||||
| Target Version | 1.5.2 | Fixed in Version | 1.5.2.svn | ||
| Summary | 0013720: [PATCH] select all items on all layers | ||||
| Description | if i activate "select object on layer" for specific layers, then i can select by click and drag all the elements on the active layer and on those layers. it would be nice if ctrl-a also would respect that setting and select all items - on the current page - on the current layer - and on the layers with "select object on layer" active | ||||
| Tags | No tags attached. | ||||
| Patch | Yes | ||||
| child of | 0003838 | acknowledged | Metabug: Scribus layers |
|
|
select-all.diff (602 bytes)
diff --git a/scribus/scribus.cpp b/scribus/scribus.cpp
index b50b49a..7881447 100644
--- a/scribus/scribus.cpp
+++ b/scribus/scribus.cpp
@@ -5040,7 +5040,7 @@ void ScribusMainWindow::SelectAll(bool docWideSelect)
for (uint a = 0; a < docItemsCount; ++a)
{
currItem = doc->Items->at(a);
- if ((currItem->LayerID == doc->activeLayer()) && (!doc->layerLocked(currItem->LayerID)))
+ if (((currItem->LayerID == doc->activeLayer()) || (doc->layerSelectable(currItem->LayerID))) && (!doc->layerLocked(currItem->LayerID)))
{
if (docWideSelect)
doc->m_Selection->addItem(currItem);
|
|
|
Tested patch. Looks like it works |
|
|
Devs, opinion? |
|
|
jghali? |
|
|
Thanks ale! Committed in r21025 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-02-10 13:04 | ale | New Issue | |
| 2016-02-10 15:35 | ale | Tag Attached: #easyhack | |
| 2016-02-10 16:24 | Kunda | Relationship added | child of 0003838 |
| 2016-02-12 16:45 | ale | File Added: select-all.diff | |
| 2016-02-12 16:45 | ale | Summary | select all items on all layers => [PATCH] select all items on all layers |
| 2016-02-12 18:43 | Kunda | Note Added: 0038672 | |
| 2016-02-13 08:58 | ale | Tag Detached: #easyhack | |
| 2016-02-13 14:06 | Kunda | Patch | No => Yes |
| 2016-02-15 12:53 | Kunda | Note Added: 0038742 | |
| 2016-02-15 12:53 | Kunda | Target Version | => 1.5.3 |
| 2016-02-15 23:01 | Kunda | Category | - => Usability |
| 2016-02-21 12:52 | Kunda | Note Added: 0038854 | |
| 2016-02-22 22:37 | cbradney | Status | new => resolved |
| 2016-02-22 22:37 | cbradney | Fixed in Version | => 1.5.2.svn |
| 2016-02-22 22:37 | cbradney | Resolution | open => fixed |
| 2016-02-22 22:37 | cbradney | Assigned To | => cbradney |
| 2016-02-27 13:16 | Kunda | Note Added: 0038914 | |
| 2016-02-27 13:16 | Kunda | Status | resolved => closed |
| 2016-02-27 13:16 | Kunda | Target Version | 1.5.3 => 1.5.2 |
