View Issue Details

IDProjectCategoryView StatusLast Update
0013848ScribusIntegrationpublic2016-04-04 01:03
Reporterjeff Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformLinuxOSFedoraOS Version23
Product Version1.5.2.svn 
Target Version1.5.2Fixed in Version1.5.2.svn 
Summary0013848: Sub-processes launched from Scribus will block the Scribus mainloop until the other application is closed
DescriptionIn the preferences, set "evince" as the preferred PDF viewer, and in the PDF export dialog check the "Open PDF after export" option.

Result: as long as Evince is open, you cannot click anything in Scribus, and GNOME's window manager considers that Scribus has gone "unresponsive". It is not immediately obvious that Scribus is blocked because of the open Evince instance (which you might want to keep side by side as you work anyway).
TagsNo tags attached.
PatchNo

Relationships

related to 0013400 closedjghali Help > Scribus Homepage hangs Scribus 

Activities

Kunda

2016-03-29 04:18

updater   ~0039485

Luya, do you mind testing this ticket?

luya

2016-03-29 18:11

reporter   ~0039520

Last edited: 2016-03-30 02:32

I confirm the issue is fully reproduced with svn21106 build.
Edit: I built 1.5.2svn to the latest version i.e svn21132, I am able to fully reproduce the bug with Evince opened.

jurajF

2016-03-30 11:27

reporter  

0001-Start-PDF-Viewer-in-background.patch (681 bytes)   
From 464fbe543e7b83ca0702763487db5a1a14e08a41 Mon Sep 17 00:00:00 2001
From: Juraj Fedel <wtxnh-scribus@yahoo.com.au>
Date: Wed, 30 Mar 2016 13:21:51 +0200
Subject: [PATCH] Start PDF Viewer in background

---
 scribus/scribus.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scribus/scribus.cpp b/scribus/scribus.cpp
index 74728e3..beb7ed9 100644
--- a/scribus/scribus.cpp
+++ b/scribus/scribus.cpp
@@ -7154,7 +7154,7 @@ void ScribusMainWindow::doSaveAsPDF()
 			{
 				QStringList args;
 				args << QDir::toNativeSeparators(doc->pdfOptions().fileName);
-				System(pdfViewer, args);
+				QProcess::startDetached(pdfViewer, args);
 			}
 		}
 	}
-- 
2.1.4

jurajF

2016-03-30 11:35

reporter   ~0039536

With included patch Scribus will launch PDF viewer as separate process that does not block Scribus. Viewer need to be closed independently of Scribus.

Kunda

2016-03-30 14:49

updater   ~0039537

is 0013400 related ?

Kunda

2016-03-30 18:36

updater   ~0039550

having issues building in OSX that seem unrelated.
Luya and jeff, would you test juraj's patch please? Thanks

jeff

2016-03-30 18:54

reporter   ~0039555

Not in a position to build and test the thing myself, but I might ask, from a theoretical standpoint: shouldn't the patch fix this for all external apps launched by scribus, not just the pdf viewer?

luya

2016-03-31 01:36

reporter   ~0039598

Last edited: 2016-03-31 01:41

Running the patch on the latest svn build solved sub-processing issue. I was able to select items from menu while keeping PDF Viewer open after selecting "Open PDF afrer Export". I am updating COPR repository as I type.
Meanwhile, the rpm version is on Koji, a Fedora build system http://koji.fedoraproject.org/koji/taskinfo?taskID=13512014

Kunda

2016-03-31 03:33

updater   ~0039599

thanks for the feedback y'all. looks like a green light, devs

jghali

2016-04-03 21:43

administrator   ~0039734

Patch applied, thanks jurajF!

Kunda

2016-04-04 01:03

updater   ~0039741

jghali applied patch in r21156
Thanks!
Closing.

Issue History

Date Modified Username Field Change
2016-03-24 17:24 jeff New Issue
2016-03-29 04:18 Kunda Note Added: 0039485
2016-03-29 18:11 luya Note Added: 0039520
2016-03-30 02:32 luya Note Edited: 0039520
2016-03-30 11:27 jurajF File Added: 0001-Start-PDF-Viewer-in-background.patch
2016-03-30 11:35 jurajF Note Added: 0039536
2016-03-30 14:49 Kunda Note Added: 0039537
2016-03-30 14:49 Kunda Relationship added related to 0013400
2016-03-30 18:36 Kunda Note Added: 0039550
2016-03-30 18:37 Kunda Status new => confirmed
2016-03-30 18:54 jeff Note Added: 0039555
2016-03-31 01:36 luya Note Added: 0039598
2016-03-31 01:41 luya Note Edited: 0039598
2016-03-31 03:33 Kunda Note Added: 0039599
2016-03-31 16:34 Kunda Target Version => 1.5.2
2016-04-03 21:43 jghali Note Added: 0039734
2016-04-03 21:43 jghali Status confirmed => resolved
2016-04-03 21:43 jghali Fixed in Version => 1.5.2.svn
2016-04-03 21:43 jghali Resolution open => fixed
2016-04-03 21:43 jghali Assigned To => jghali
2016-04-04 01:03 Kunda Note Added: 0039741
2016-04-04 01:03 Kunda Status resolved => closed