View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0016388 | Scribus | User Interface | public | 2020-12-14 20:36 | 2021-03-21 15:29 |
| Reporter | bubu | Assigned To | jghali | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.5.7.svn | ||||
| Fixed in Version | 1.5.7.svn | ||||
| Summary | 0016388: Add missing vertical spacer to Create Range dialog | ||||
| Description | There is a missing vertical spacer in Create Range dialog after "Add to Range" button. See the before-after screenshot, please. This dialog can be found for example by: - File > Print > Print Range ... - File > Export > Save As PDF > Choose Pages ... - Insert > Frames > Location tab -> Range of Pages ... This patch adds the missing vertical spacer and shrinks a little bit the height of the dialog. The patch seems big because spacer is inserted to a grid layout but it is really just an inserted spacer, nothing else. Please review the patch. Thanks. | ||||
| Tags | patch | ||||
| Patch | Yes | ||||
|
|
create_range.diff (9,085 bytes)
diff --git a/scribus/ui/createrange.ui b/scribus/ui/createrange.ui
index a0e5e058af60b28a2c1856e7c8a1ae4590835aa4..ce0583279fa3699884aadd1430925bc6810d827f 100644
--- a/scribus/ui/createrange.ui
+++ b/scribus/ui/createrange.ui
@@ -7,7 +7,7 @@
<x>0</x>
<y>0</y>
<width>605</width>
- <height>437</height>
+ <height>386</height>
</rect>
</property>
<property name="windowTitle">
@@ -80,64 +80,6 @@
<string>Basic Range Selection</string>
</attribute>
<layout class="QGridLayout">
- <item row="0" column="1">
- <widget class="QGroupBox" name="groupBox1">
- <property name="title">
- <string>Range of Pages</string>
- </property>
- <layout class="QGridLayout">
- <item row="2" column="1">
- <widget class="QPushButton" name="basicRangeDelButton">
- <property name="text">
- <string>De&lete</string>
- </property>
- <property name="shortcut">
- <string>Alt+L</string>
- </property>
- </widget>
- </item>
- <item row="3" column="1">
- <spacer>
- <property name="orientation">
- <enum>Qt::Vertical</enum>
- </property>
- <property name="sizeType">
- <enum>QSizePolicy::Expanding</enum>
- </property>
- <property name="sizeHint" stdset="0">
- <size>
- <width>20</width>
- <height>40</height>
- </size>
- </property>
- </spacer>
- </item>
- <item row="1" column="1">
- <widget class="QPushButton" name="basicRangeDownButton">
- <property name="text">
- <string>Move &Down</string>
- </property>
- <property name="shortcut">
- <string>Alt+D</string>
- </property>
- </widget>
- </item>
- <item row="0" column="1">
- <widget class="QPushButton" name="basicRangeUpButton">
- <property name="text">
- <string>Move &Up</string>
- </property>
- <property name="shortcut">
- <string>Alt+U</string>
- </property>
- </widget>
- </item>
- <item row="0" column="0" rowspan="4">
- <widget class="QListWidget" name="basicRangeListBox"/>
- </item>
- </layout>
- </widget>
- </item>
<item row="0" column="0">
<widget class="QGroupBox" name="basicAddARangeButtonGroup">
<property name="sizePolicy">
@@ -160,49 +102,26 @@
</property>
</widget>
</item>
- <item row="4" column="0" colspan="5">
- <widget class="QRadioButton" name="basicEvenRadioButton">
- <property name="text">
- <string>Even Pages</string>
- </property>
- </widget>
+ <item row="1" column="1">
+ <widget class="ScrSpinBox" name="basicConsecutiveFromSpinBox"/>
</item>
- <item row="1" column="0">
- <widget class="QLabel" name="basicConsecutiveFromLabel">
+ <item row="3" column="0" colspan="5">
+ <widget class="QLineEdit" name="basicCommaSepLineEdit"/>
+ </item>
+ <item row="5" column="0" colspan="5">
+ <widget class="QRadioButton" name="basicOddRadioButton">
<property name="text">
- <string>From:</string>
- </property>
- <property name="wordWrap">
- <bool>false</bool>
+ <string>Odd Pages</string>
</property>
</widget>
</item>
<item row="1" column="3">
<widget class="ScrSpinBox" name="basicConsecutiveToSpinBox"/>
</item>
- <item row="1" column="1">
- <widget class="ScrSpinBox" name="basicConsecutiveFromSpinBox"/>
- </item>
- <item row="1" column="4">
- <spacer>
- <property name="orientation">
- <enum>Qt::Horizontal</enum>
- </property>
- <property name="sizeType">
- <enum>QSizePolicy::Expanding</enum>
- </property>
- <property name="sizeHint" stdset="0">
- <size>
- <width>40</width>
- <height>20</height>
- </size>
- </property>
- </spacer>
- </item>
- <item row="1" column="2">
- <widget class="QLabel" name="basicConsecutiveToLabel">
+ <item row="1" column="0">
+ <widget class="QLabel" name="basicConsecutiveFromLabel">
<property name="text">
- <string>To:</string>
+ <string>From:</string>
</property>
<property name="wordWrap">
<bool>false</bool>
@@ -255,15 +174,38 @@
</item>
</layout>
</item>
- <item row="5" column="0" colspan="5">
- <widget class="QRadioButton" name="basicOddRadioButton">
+ <item row="4" column="0" colspan="5">
+ <widget class="QRadioButton" name="basicEvenRadioButton">
<property name="text">
- <string>Odd Pages</string>
+ <string>Even Pages</string>
</property>
</widget>
</item>
- <item row="3" column="0" colspan="5">
- <widget class="QLineEdit" name="basicCommaSepLineEdit"/>
+ <item row="1" column="4">
+ <spacer>
+ <property name="orientation">
+ <enum>Qt::Horizontal</enum>
+ </property>
+ <property name="sizeType">
+ <enum>QSizePolicy::Expanding</enum>
+ </property>
+ <property name="sizeHint" stdset="0">
+ <size>
+ <width>40</width>
+ <height>20</height>
+ </size>
+ </property>
+ </spacer>
+ </item>
+ <item row="1" column="2">
+ <widget class="QLabel" name="basicConsecutiveToLabel">
+ <property name="text">
+ <string>To:</string>
+ </property>
+ <property name="wordWrap">
+ <bool>false</bool>
+ </property>
+ </widget>
</item>
<item row="2" column="0" colspan="5">
<widget class="QRadioButton" name="basicCommaSepRadioButton">
@@ -272,6 +214,77 @@
</property>
</widget>
</item>
+ <item row="7" column="0">
+ <spacer name="verticalSpacer">
+ <property name="orientation">
+ <enum>Qt::Vertical</enum>
+ </property>
+ <property name="sizeHint" stdset="0">
+ <size>
+ <width>20</width>
+ <height>0</height>
+ </size>
+ </property>
+ </spacer>
+ </item>
+ </layout>
+ </widget>
+ </item>
+ <item row="0" column="1">
+ <widget class="QGroupBox" name="groupBox1">
+ <property name="title">
+ <string>Range of Pages</string>
+ </property>
+ <layout class="QGridLayout">
+ <item row="2" column="1">
+ <widget class="QPushButton" name="basicRangeDelButton">
+ <property name="text">
+ <string>De&lete</string>
+ </property>
+ <property name="shortcut">
+ <string>Alt+L</string>
+ </property>
+ </widget>
+ </item>
+ <item row="3" column="1">
+ <spacer>
+ <property name="orientation">
+ <enum>Qt::Vertical</enum>
+ </property>
+ <property name="sizeType">
+ <enum>QSizePolicy::Expanding</enum>
+ </property>
+ <property name="sizeHint" stdset="0">
+ <size>
+ <width>20</width>
+ <height>40</height>
+ </size>
+ </property>
+ </spacer>
+ </item>
+ <item row="1" column="1">
+ <widget class="QPushButton" name="basicRangeDownButton">
+ <property name="text">
+ <string>Move &Down</string>
+ </property>
+ <property name="shortcut">
+ <string>Alt+D</string>
+ </property>
+ </widget>
+ </item>
+ <item row="0" column="1">
+ <widget class="QPushButton" name="basicRangeUpButton">
+ <property name="text">
+ <string>Move &Up</string>
+ </property>
+ <property name="shortcut">
+ <string>Alt+U</string>
+ </property>
+ </widget>
+ </item>
+ <item row="0" column="0" rowspan="4">
+ <widget class="QListWidget" name="basicRangeListBox"/>
+ </item>
</layout>
</widget>
</item>
|
|
|
Applied, thanks! |
|
|
Thanks! Fixed in 1.5.7.svn (24321) |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-12-14 20:36 | bubu | New Issue | |
| 2020-12-14 20:36 | bubu | Tag Attached: patch | |
| 2020-12-14 20:36 | bubu | File Added: create_range.diff | |
| 2020-12-14 20:36 | bubu | File Added: create_range.gif | |
| 2020-12-14 21:43 | jghali | Assigned To | => jghali |
| 2020-12-14 21:43 | jghali | Status | new => resolved |
| 2020-12-14 21:43 | jghali | Resolution | open => fixed |
| 2020-12-14 21:43 | jghali | Fixed in Version | => 1.5.7.svn |
| 2020-12-14 21:43 | jghali | Note Added: 0048552 | |
| 2021-03-21 15:29 | FirasH | Status | resolved => closed |
| 2021-03-21 15:29 | FirasH | Note Added: 0049030 |
