View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0017216 | Scribus | Build System | public | 2024-05-12 05:28 | 2024-05-14 18:38 |
Reporter | AkiSakurai | Assigned To | |||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | no change required | ||
Product Version | 1.7.0.svn | ||||
Summary | 0017216: The pkg_search_module of PoDoFo should be optional. | ||||
Description | There are no pkgconfig for PoDoFo on Homebrew, we should be able to find it using the header and library paths only. index ca910a89b..433ba90b6 100644 --- a/cmake/modules/FindLIBPODOFO.cmake +++ b/cmake/modules/FindLIBPODOFO.cmake @@ -18,7 +18,7 @@ find_package(PkgConfig QUIET) if(DEFINED LIBPODOFO_DIR_PREFIX) set(ENV{PKG_CONFIG_PATH} "${LIBPODOFO_DIR_PREFIX}/lib/pkgconfig:$ENV{PKG_CONFIG_PATH}") endif() -pkg_search_module(libpodofo REQUIRED libpodofo podofo) +pkg_search_module(libpodofo libpodofo podofo) | ||||
Tags | No tags attached. | ||||
Patch | No | ||||
|
All you're changing is whether podofo is required or not. We want Scribus to have podofo at build time. As for whether HomeBrew has the pkgconfig file, thats a different problem that is upstream. |
|
Resolved by upstream. https://github.com/Homebrew/homebrew-core/commit/01a803f569315990bea29634a7e6fda201833a46 |
Date Modified | Username | Field | Change |
---|---|---|---|
2024-05-12 05:28 | AkiSakurai | New Issue | |
2024-05-12 19:12 | cbradney | Note Added: 0051146 | |
2024-05-14 05:24 | AkiSakurai | Note Added: 0051149 | |
2024-05-14 07:34 | ale | Status | new => resolved |
2024-05-14 07:34 | ale | Resolution | open => fixed |
2024-05-14 07:34 | ale | Status | resolved => closed |
2024-05-14 18:38 | jghali | Resolution | fixed => no change required |