View Issue Details

IDProjectCategoryView StatusLast Update
0002120ScribusGraphics / Image Framespublic2005-07-02 08:15
Reporterfschmid Assigned Toringerc 
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version1.3.0cvs 
Fixed in Version1.2.2cvs 
Summary0002120: Some sort of jpeg images can't be loaded
DescriptionSome sort of jpeg images can't be loaded
TagsNo tags attached.
Patch

Relationships

related to 0000349 closedringerc If a file is saved under a default name under a non-English locale it does not show up in the "Recent documents" submenu. 
child of 0002215 closedjghali Audit and fix text encoding handling 

Activities

2005-06-24 04:00

 

Fläche_farbig_2004.jpg (119,733 bytes)   
Fläche_farbig_2004.jpg (119,733 bytes)   

cbradney

2005-06-24 20:35

administrator   ~0005115

Works ok here.

ringerc

2005-06-25 03:28

reporter   ~0005119

Last edited: 2005-06-25 03:29

They won't load at all here; the image frame retains it's X.

fschmid

2005-06-29 17:36

developer   ~0005230

Only solution is currently to remove the german umlaut ä in the filename, eg. if you rename it to flaeche_farbig_2004.jpg it loads perfectly.

cbradney

2005-06-29 17:42

administrator   ~0005231

Works ok here in 1.2.2 and 1.3.0 WITH the umlaut. What are you not seeing working? Import to the page, export to PDF? or?

plinnell

2005-06-29 18:17

viewer   ~0005232

>Only solution is currently to remove the german umlaut ä in the filename, eg. if > you rename it to flaeche_farbig_2004.jpg it loads perfectly.

Same here and it won't even display in the file selector preview. If you try to print preview the file, the preflight tool shows missing image.

cbradney

2005-06-29 18:19

administrator   ~0005233

File selector preview works here with umlaut.

fschmid

2005-06-29 21:38

developer   ~0005243

The image is originated from a Fedora Core 3 or 4 distro, and on SuSE 9.1 the umlaut is somewhat incorrectly converted. You see only two empty squares for the umlaut in Konquerer.

ringerc

2005-06-30 00:18

reporter   ~0005244

Sounds like an encoding handling bug in the file loading routines to me. We're probably treating an incoming utf-8 filename as latin-1.

If I set my locale to:

LANG=C
LC_ALL=C

it works; with default UTF-8 encoding it does not. I'll look for it, since I have some experience with this stuff.

ringerc

2005-07-02 07:18

reporter   ~0005324

We're not telling Qt to respect the local text encoding. By default, it does QString<->byte string conversions by *assuming* that the incoming text is latin-1. If your locale is `de_DE', `en_US', `en_AU' etc, that's fine. If, however, you use a UTF-8 locale, or a different text encoding, you'll get weird mangling of some text.

Qt provides QString::fromLocal8Bit(...) and QString::local8Bit() so we can be explicit about these conversions. We don't use them, and instead in most places seem to assume the user is in a UTF-8 locale, or just hope they aren't trying to use any 8-bit characters. In other places, we explicitly use QTextCodec to convert to/from local 8 bit text.

After 1.3.0 is released, I think we need to change this so that we default to doing 8-bit string I/O in the encoding of the current locale. That change will only affect places where the code already does the wrong thing, and should cause those places to work correctly.

Until we do that, you need to remember never to implicitly convert a QString to a char* - always use .local8Bit() .

ringerc

2005-07-02 07:46

reporter   ~0005327

backported to 1.2.2cvs

plinnell

2005-07-02 07:48

viewer   ~0005328

now fixed in 1.3

plinnell

2005-07-02 08:15

viewer   ~0005329

tested on suse 9.2 and 9.1. works fine now

Issue History

Date Modified Username Field Change
2005-06-24 04:00 fschmid New Issue
2005-06-24 04:00 fschmid File Added: Fläche_farbig_2004.jpg
2005-06-24 20:35 cbradney Note Added: 0005115
2005-06-25 03:28 ringerc Note Added: 0005119
2005-06-25 03:29 ringerc Note Edited: 0005119
2005-06-29 17:36 fschmid Note Added: 0005230
2005-06-29 17:42 cbradney Note Added: 0005231
2005-06-29 18:17 plinnell Note Added: 0005232
2005-06-29 18:19 cbradney Note Added: 0005233
2005-06-29 21:38 fschmid Note Added: 0005243
2005-06-30 00:18 ringerc Note Added: 0005244
2005-06-30 00:19 ringerc Status new => assigned
2005-06-30 00:19 ringerc Assigned To => ringerc
2005-07-02 07:18 ringerc Note Added: 0005324
2005-07-02 07:37 ringerc Status assigned => resolved
2005-07-02 07:37 ringerc Fixed in Version => 1.3.0cvs
2005-07-02 07:37 ringerc Resolution open => fixed
2005-07-02 07:46 ringerc Note Added: 0005327
2005-07-02 07:46 ringerc Fixed in Version 1.3.0cvs => 1.2.2cvs
2005-07-02 07:48 plinnell Note Added: 0005328
2005-07-02 07:56 ringerc Relationship added related to 0000349
2005-07-02 08:15 plinnell Note Added: 0005329
2005-07-02 08:15 plinnell Status resolved => closed
2005-07-10 03:01 ringerc Relationship added child of 0002215
2015-09-17 20:10 Kunda Category Graphics / Image Frames => Graphics/Img Frames
2015-09-17 20:11 Kunda Category Graphics/Img Frames => Graphics / Image Frames