View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002322 | Scribus | Internal | public | 2005-07-28 16:59 | 2005-09-22 22:56 |
| Reporter | Assigned To | fschmid | |||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | x86 Linux | OS | Fedora Core | OS Version | 3 |
| Fixed in Version | 1.3.1cvs | ||||
| Summary | 0002322: Rename CMYKColor to ScColor | ||||
| Description | The attached patch renames CMYKColor to ScColor, to reduce confusion. Objections? It also converts files over to use sccolor.h . That currently just pulls in cmykcolor.h but when we can move files around properly cmykcolor.{h,cpp} should be renamed to sccolor.{h,cpp}. | ||||
| Additional Information | Once this is done I think we need to make colors in prefs clearer. I'd like to move them over to the new prefs API and do away with the <COLOR RGB='xxxx' CMYK='xxxx' NAME='xxxx'> stuff in favour of storing: - Color name - name/number to use in spot colour in ps/pdf (if blank, defaults to color name) - colour co-ordinate scheme <= {CMYK, RGB, RGBA, CMY, hexachrome, L*A*B, ... } - colour co-ordinates as a scheme-specific string. so we might have something like (pseudo-code; would actually be prefs-api XML): <color> <name>Cyan</name> <spotname>CYAN001</spotname> <scheme>CMYK</scheme> <coords>0xFF000000</coords> </color> We might also want to store a profile indicating what colour space the colour is defined in relation to? I'm not sure. Do we currently assume doc RGB colours are in the monitor colourspace? In sRGB? What? What about the case where we don't support colour management? CMYK is even harder, since we don't even have any standard profile like sRGB that we can treat colours as being in. [I'll move this to the wiki later] | ||||
| Tags | No tags attached. | ||||
| Patch | |||||
|
2005-07-28 16:59
|
|
|
2005-07-28 16:59
|
sccolor.h (1,308 bytes)
/***************************************************************************
cmykcolor.h - description
-------------------
begin : Sun Sep 9 2001
copyright : (C) 2001 by Franz Schmid
email : Franz.Schmid@altmuehlnet.de
***************************************************************************/
/***************************************************************************
* *
* This program is free software; you can redistribute it and/or modify *
* it under the terms of the GNU General Public License as published by *
* the Free Software Foundation; either version 2 of the License, or *
* (at your option) any later version. *
* *
***************************************************************************/
#ifndef _SCCOLOR_H
#define _SCCOLOR_H
/*
* ScColor is still defined in cmykcolor.h . When we move to svn and can easily move
* files around this will get fixed. In the mean time you should include this
* file, and it'll pull in cmykcolor.h .
*/
#include "cmykcolor.h"
#endif
|
|
|
>>We might also want to store a profile indicating what colour space the colour is defined in relation to? I'm not sure. If color profile is known, L*A*B* is also known, so storing concurrently L*A*B* value is maybe more interesting.. Thoughts? |
|
|
Adjusted the Makefile.am too and copied the cmykcolor.cpp/.h files to sccolor.cpp/.h to avoid confusion having both versions. I don't like include files that just include another file. |
|
|
The problem is we have now lost these files history. We should be using the workarounds and migrating to SVN ASAP and then renaming and moving files around. |
|
|
These files should have gone into the Attic directory of the CVS-Repository, cervisia doesn't show this dir, but the history of the files should be kept there. |
|
|
Yes, but renaming in SVN would keep all the history together with the file, even after renaming, or moving to a new dir even. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-07-28 16:59 |
|
New Issue | |
| 2005-07-28 16:59 |
|
File Added: sccolor.diff.gz | |
| 2005-07-28 16:59 |
|
File Added: sccolor.h | |
| 2005-07-28 17:36 | jghali | Note Added: 0005769 | |
| 2005-07-28 19:11 | fschmid | Status | new => resolved |
| 2005-07-28 19:11 | fschmid | Fixed in Version | => 1.3.1cvs |
| 2005-07-28 19:11 | fschmid | Resolution | open => fixed |
| 2005-07-28 19:11 | fschmid | Assigned To | => fschmid |
| 2005-07-28 19:11 | fschmid | Note Added: 0005771 | |
| 2005-07-28 19:41 | cbradney | Note Added: 0005772 | |
| 2005-07-28 21:42 | fschmid | Note Added: 0005773 | |
| 2005-07-28 21:54 | cbradney | Note Added: 0005774 | |
| 2005-09-17 07:30 |
|
Relationship added | related to 0002167 |
| 2005-09-22 22:56 | cbradney | Status | resolved => closed |
