View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002764 | Scribus | Internal | public | 2005-10-26 02:29 | 2005-11-30 20:05 |
| Reporter | Assigned To | ||||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | x86 Linux | OS | Fedora Core | OS Version | 3 |
| Product Version | 1.3.2cvs | ||||
| Fixed in Version | 1.3.2cvs | ||||
| Summary | 0002764: Opening a gzipped doc with new encoding-correct readSla(...) takes FOREVER | ||||
| Description | The new encoding-correct readSLA(...) is extremely slow when reading gzipped docs. It looks like it's getting hung up in QCString::append(...) and/or QCString::operator+= , probably due to excessive memory allocations. | ||||
| Tags | No tags attached. | ||||
| Patch | |||||
|
|
This might be the same reason that PDF export is now unreasonably slow. |
|
|
The problem is a specific issue with one method, FileLoader::readSLA(...) , that is only called by scribusXml.cpp and fileloader.cpp during the reading of .sla.gz files from disk. As such, I don't see how it could affect PDF export. It's possible that if something has changed in PDF export to use a QCString or QByteArray in an append loop then the same underlying issue exists with PDF export. I'm not aware of any such change - AFAIK it still (ab)uses QString, which internally optimises allocations, to store its byte strings. |
|
|
Hmm, yes. Its slow, however I checked, and 1.3.0 is slow too. I have a few const QString&s to go into parameters in PDF export but it doesnt seem to change much, however avox says his profiler shows the QString constructor and destructor to be a major time factor, as well as the compress2 function called from compressStr in util.cpp. |
|
|
*much* better now |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-10-26 02:29 |
|
New Issue | |
| 2005-10-26 02:32 |
|
Relationship added | related to 0002761 |
| 2005-11-06 22:07 | cbradney | Note Added: 0007363 | |
| 2005-11-07 06:48 |
|
Note Added: 0007367 | |
| 2005-11-07 07:37 | cbradney | Note Added: 0007368 | |
| 2005-11-27 20:27 |
|
Status | assigned => resolved |
| 2005-11-27 20:27 |
|
Fixed in Version | => 1.3.2cvs |
| 2005-11-27 20:27 |
|
Resolution | open => fixed |
| 2005-11-30 20:05 |
|
Status | resolved => closed |
| 2005-11-30 20:05 |
|
Note Added: 0007593 |
