View Issue Details

IDProjectCategoryView StatusLast Update
0002991ScribusOS-Win32public2006-12-23 17:53
Reporterjo-hannes Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.3.3cvs 
Fixed in Version1.3.4cvs 
Summary0002991: Path separators should be a backslash on windows
Descriptionnot a slash like in unix
TagsNo tags attached.
Patch

Relationships

parent of 0003169 closedcbradney Path separators in recent file menu should be a backslash on windows 
has duplicate 0003969 closed Windows port: make file paths windowslike 
child of 0003964 closedplinnell 1.3.4 Release Metabug 

Activities

jghali

2006-01-10 17:36

administrator   ~0008009

Translation between path separators is done by qt. Internally all paths uses unix-style separators. So should affect display only.

2006-01-10 20:04

 

win32filepaths.png (43,667 bytes)   
win32filepaths.png (43,667 bytes)   

subik

2006-01-11 12:00

manager   ~0008031

I'm writting QDir::convertSeparators in loading/saving.

subik

2006-01-12 11:11

manager   ~0008041

jghali, can you notice me when you finish next win build to test it, please?

jghali

2006-01-12 14:29

administrator   ~0008043

Seems to work ok except one little thing : when you open a new file, the file is still displayed with slashes in recent file menu (see recent_files_slashes.png )

2006-01-12 14:29

 

recent_files_slashes.png (142,006 bytes)   
recent_files_slashes.png (142,006 bytes)   

jo-hannes

2006-01-12 17:28

developer   ~0008044

the filename in the title bar is also wrong

subik

2006-01-12 20:34

manager   ~0008045

[20:57:36] <subik> I have some issue with 2991 (/ in windows dirs)
[20:57:45] <subik> I cannot test it on linux
[20:58:05] <subik> there is a lot of "/" magic
[20:59:00] <subik> void ScribusMainWindow::startUpDialog()
[20:59:08] <subik> bool ScribusMainWindow::slotFileNew()
[21:00:28] <subik> there should be QDdir::convertSeparators() wrapper around QString fileName definition. Can you dive in it now?
[21:04:00] <jghali> subik: excuse me, was discussing with jo-hannes, going to do it now
[21:05:25] <subik> no prob ;)
[21:05:50] <subik> but beware. it can break all document loading imho
[21:07:30] <jghali> subik: i think 2991 should not be qualified as major: does not prevent scribus from wroking
[21:09:42] <jghali> if it were me i would have waited 1.3.2 release
[21:19:25] <subik> jghali: ok, we will fix it after release... imho there we will have to rewrite some ugly hacks with file path done by QString::find() to QFile and QDir :-/

jghali

2006-01-12 21:34

administrator   ~0008046

changing ScribusMainWindow::updateRecent and ScribusMainWindow::removeRecent fix the issue a bit more

void ScribusMainWindow::updateRecent(QString fn)
{
    QString platfname = QDir::convertSeparators(fn);
    if (RecentDocs.findIndex(platfname) == -1)
    {
        RecentDocs.prepend(platfname);
        fileWatcher->addFile(fn);
    }
    else
    {
        RecentDocs.remove(platfname);
        RecentDocs.prepend(platfname);
    }
    rebuildRecentFileMenu();
}

void ScribusMainWindow::removeRecent(QString fn)
{
    QString platfname = QDir::convertSeparators(fn);
    if (RecentDocs.findIndex(platfname) != -1)
    {
        RecentDocs.remove(platfname);
        if (!fileWatcher->isActive())
            fileWatcher->removeFile(fn);
    }
    rebuildRecentFileMenu();
}

jghali

2006-01-12 22:50

administrator   ~0008047

void ScribusMainWindow::loadRecent(QString fn)
{
    QFileInfo fd(fn);
    if (!fd.exists())
    {
        RecentDocs.remove(QDir::convertSeparators(fn));
        fileWatcher->removeFile(fn);
        rebuildRecentFileMenu();
        return;
    }
    loadDoc(fn);
}

cbradney

2006-01-12 22:55

administrator   ~0008048

Committed that stuff Jean noted

jo-hannes

2006-01-13 08:02

developer   ~0008054

Last edited: 2006-01-13 08:04

still wrong in
- preferences (docs, icc profiles...) and external tools and plugin-list.
- manage pictures
- open file / save file

jo-hannes

2006-01-13 13:50

developer   ~0008062

now there are multiple entries of the same files in the recent files menu on windows.

jghali

2006-01-13 14:18

administrator   ~0008063

you should reset the recent file list by erasing RECENT elements in scribus13.rc, have seen the same phenomenon, but it disappeared after doing so.

jo-hannes

2006-01-13 14:35

developer   ~0008064

that works, thx.

jghali

2006-01-13 15:31

administrator   ~0008066

hmm, does not work so well, when closing and opening again, duplicates really appear in recent file list...

jghali

2006-01-14 14:40

administrator   ~0008083

well, after more testing, it has appeared that a non complete fix has more chance to trigger bugs than anything else. Committed changes have been reverted. Safer to wait for 1.3.2 release... Really...

ringerc

2006-01-14 20:53

reporter   ~0008087

In surprising places things that appear to be "just for display" may be used for I/O, stored in prefs, etc as well.

I was bitten by this, though not with file separators, when renaming some GUI text in the PDF dialog. It turned out that the combo box text ended up in the PDF file...

Whenever you change a GUI element's display you'll probably have to find all places in the code that access its value (ie the text of a combo box item) and make sure they don't send it anywhere unexpected and silly.

cbradney

2006-02-03 00:08

administrator   ~0008536

Fixed recent file menu.

jo-hannes

2006-02-03 22:26

developer   ~0008555

making non-private as windows version has been released.

2006-07-04 09:19

 

linux_paths_on_win_1.png (23,395 bytes)   
linux_paths_on_win_1.png (23,395 bytes)   

mhanski

2006-07-04 09:21

developer   ~0011788

Please don't use ./ or ../ because it will surely miss the targeted audience (see the attached screenshot linux_paths_on_win_1.png)

Tsoots

2006-08-20 23:19

reporter   ~0012250

Last edited: 2006-08-20 23:35

-file/dir dialogs (CustomFDialog?)
-print dialog/file:
 (print is different to file dialog tho.. custom dialog,
  dont forget alternative print command too for print dialog)
-new file dialog, open existing doc
*title bar file name*
*windows menu*
-prefs->general directories
-prefs->fonts additional paths
-prefs->external apps
*warning for unsaved doc*
-export as image dialog

jghali

2006-11-24 19:41

administrator   ~0013551

Most of the issue should be now fixed in 1.3.4cvs, except file dialogs which are not fixable without patching qt.

Issue History

Date Modified Username Field Change
2006-01-10 17:16 jo-hannes New Issue
2006-01-10 17:36 jghali Note Added: 0008009
2006-01-10 20:01 plinnell Assigned To => ltning
2006-01-10 20:01 plinnell Status new => assigned
2006-01-10 20:04 plinnell File Added: win32filepaths.png
2006-01-10 20:41 cbradney Assigned To ltning =>
2006-01-11 11:57 subik Assigned To => subik
2006-01-11 12:00 subik Note Added: 0008031
2006-01-12 11:11 subik Note Added: 0008041
2006-01-12 14:29 jghali Note Added: 0008043
2006-01-12 14:29 jghali File Added: recent_files_slashes.png
2006-01-12 17:28 jo-hannes Note Added: 0008044
2006-01-12 20:34 subik Note Added: 0008045
2006-01-12 20:44 jghali Severity major => minor
2006-01-12 21:34 jghali Note Added: 0008046
2006-01-12 22:50 jghali Note Added: 0008047
2006-01-12 22:55 cbradney Note Added: 0008048
2006-01-13 08:02 jo-hannes Note Added: 0008054
2006-01-13 08:04 jo-hannes Note Edited: 0008054
2006-01-13 13:50 jo-hannes Note Added: 0008062
2006-01-13 14:18 jghali Note Added: 0008063
2006-01-13 14:35 jo-hannes Note Added: 0008064
2006-01-13 15:31 jghali Note Added: 0008066
2006-01-14 14:40 jghali Note Added: 0008083
2006-01-14 20:53 ringerc Note Added: 0008087
2006-01-15 14:09 plinnell Product Version 1.3.2cvs => 1.3.3cvs
2006-02-03 00:08 cbradney Note Added: 0008536
2006-02-03 00:13 cbradney Relationship added parent of 0003169
2006-02-03 22:26 jo-hannes Note Added: 0008555
2006-02-03 22:26 jo-hannes View Status private => public
2006-07-04 08:10 jo-hannes Relationship added has duplicate 0003969
2006-07-04 09:19 mhanski File Added: linux_paths_on_win_1.png
2006-07-04 09:21 mhanski Note Added: 0011788
2006-08-20 22:50 cbradney Relationship added child of 0003964
2006-08-20 23:19 Tsoots Note Added: 0012250
2006-08-20 23:28 Tsoots Note Edited: 0012250
2006-08-20 23:28 Tsoots Note Edited: 0012250
2006-08-20 23:29 Tsoots Note Edited: 0012250
2006-08-20 23:32 Tsoots Note Edited: 0012250
2006-08-20 23:35 Tsoots Note Edited: 0012250
2006-11-21 21:43 jghali Assigned To subik => jghali
2006-11-24 19:41 jghali Note Added: 0013551
2006-12-05 18:44 jghali Status assigned => resolved
2006-12-05 18:44 jghali Fixed in Version => 1.3.4cvs
2006-12-05 18:44 jghali Resolution open => fixed
2006-12-23 17:52 cbradney Status resolved => closed
2014-10-08 18:38 Kunda Category Win32 => OS-Win32